Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix numbering of chapters, fix #944. #991

Merged
merged 1 commit into from
Jan 14, 2019
Merged

doc: fix numbering of chapters, fix #944. #991

merged 1 commit into from
Jan 14, 2019

Conversation

fredrikekre
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 14, 2019
@bors @fredrikekre
Merge #991
4411ffd 
991: doc: fix numbering of chapters, fix #944. r=fredrikekre a=fredrikekre

bors r+

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
StefanKarpinski
StefanKarpinski approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but why are we numbering chapters manually like this? Do we need numbers?

@bors
Copy link
Contributor

bors bot commented Jan 14, 2019

Build succeeded

@bors bors bot merged commit 73d2ebc into master Jan 14, 2019
@bors bors bot deleted the fe/docs branch January 14, 2019 14:23
@fredrikekre
Copy link
Member Author

Seems good but why are we numbering chapters manually like this?

Because there is no other way with Documenter currently. We have few enough chapters that I think this is sustainable.

Do we need numbers?

Not sure we "need" it, but it looks much better IMO. Compare the structure and "general feeling" of Pkg vs Julias manual.

@StefanKarpinski
Copy link
Member

Fair enough. The number is quite nice.

fredrikekre added a commit that referenced this pull request Feb 11, 2019
@fredrikekre
doc: fix numbering of chapters, fix #944.
a71e66a 
(cherry picked from commit 73d2ebc, PR #991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @StefanKarpinski